Add key type to internal relation keys in pg_tde: #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a key type to internal relation keys, allowing segregation of SMGR and heap_basic internal keys. It resolves the issue of double encryption when both tde_heap and tde_heap_basic access methods are in use. With this enhancement, pg_tde now supports three types of internal keys: SMGR keys, heap_basic keys, and global keys, improving flexibility and preventing redundant encryption operations.
dAdAbird
approved these changes
Oct 21, 2024
| rloc.dbOid = principal_key->keyInfo.databaseId; | ||
| rloc.spcOid = DEFAULTTABLESPACE_OID; | ||
| rloc.spcOid = DEFAULTTABLESPACE_OID; /* TODO. Revisit*/ |
There was a problem hiding this comment.
we need to test key rotation in non-default table space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a key type to internal relation keys, allowing segregation of SMGR and heap_basic internal keys. It resolves the issue of double encryption when both tde_heap and tde_heap_basic access methods are in use.
With this enhancement, pg_tde now supports three types of internal keys: SMGR keys, heap_basic keys, and global keys, improving flexibility and preventing redundant encryption operations.